Re: [PATCH 2/2] taskset: make threads aware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2011 at 06:03:09PM -0400, Davidlohr Bueso wrote:
>  schedutils/taskset.1 |    3 ++
>  schedutils/taskset.c |   90 +++++++++++++++++++++++++++++++++----------------
>  2 files changed, 63 insertions(+), 30 deletions(-)

Applied with some changes, thanks.

> +	printf(_("pid %d's %s affinity %s: %s\n"), pid, state, str, cpuset);

This is not too friendly to .po files translators...

> +static void do_taskset(pid_t pid, int get_only, cpu_set_t *new_set, size_t new_setsize,
> +		       cpu_set_t *cur_set, size_t cur_setsize, int c_opt, char *buf, size_t buflen)

I have added a new "struct taskset".

> +	if (argc - optind == 1)
> +		get_only = 1;
>  
>  	rc = c_opt ? cpulist_parse(argv[optind], new_set, new_setsize) :
>  		     cpumask_parse(argv[optind], new_set, new_setsize);

This is incorrect, argv[optind] should not be parsed if get_only is 1.

Thanks!

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux