Re: [PATCH 0/8] ul: maintenance fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 3, 2011 at 12:18, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Sat, Apr 30, 2011 at 01:06:19PM +0200, Sami Kerola wrote:
>> Perhaps the most interesting change is the FIXME comment,
>> which is asking about override setting. See the patch 5 for
>> details, if you are interested to solve a legacy mystery.
>
> Not sure, but probably something like
>
>  ul <file> | lpr
>
> and if you have a special terminfo database for 'lpr' then you
> can probably generate output for the printer.

I found the same if statement from 4.3BSD source, published at
1985. My feeling is that no-one knows about or needs the
functionality.


On Tue, May 3, 2011 at 13:57, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Sat, Apr 30, 2011 at 01:06:20PM +0200, Sami Kerola wrote:
[snip]
>> +static void print_line(char *line);
>
> Is it good name for the function? It does not print a line. It
> prints some chars without care about \n.

Good point. 's/print_line/print_out/' done. I don't know is that
very descriptive function name, but perhaps it's better to be
vaguely right, than precisely wrong.


On Tue, May 3, 2011 at 12:20, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Sat, Apr 30, 2011 at 01:06:27PM +0200, Sami Kerola wrote:
>> Happens usually when user specifies garbage as -t argument.
[snip]
>
> add 'tflag' for -t/-T and
>
>  if (tflag)
>     warnx(_("terminal `%s' is not ....);

The if is added.


Fixed patches are also available via github from address bellow.
The branch name, for these patches, is `ul'.

git://github.com/kerolasa/lelux-utiliteetit.git

-- 
   Sami Kerola
   http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux