Re: [PATCH 1/8] ul.c: convert definition to function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 30, 2011 at 01:06:20PM +0200, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> ---
>  text-utils/ul.c |   39 +++++++++++++++++++++++----------------
>  1 files changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/text-utils/ul.c b/text-utils/ul.c
> index dc0550c..2638939 100644
> --- a/text-utils/ul.c
> +++ b/text-utils/ul.c
> @@ -80,6 +80,7 @@ void setmode(int newmode);
>  static void setcol(int newcol);
>  static void needcol(int col);
>  static void sig_handler(int signo);
> +static void print_line(char *line);
>  
>  #define	IESC	'\033'
>  #define	SO	'\016'
> @@ -115,8 +116,6 @@ int	halfpos;
>  int	upln;
>  int	iflag;
>  
> -#define	PRINT(s)	if (s == NULL) /* void */; else putwp(s)
> -
>  int main(int argc, char **argv)
>  {
>  	int c, ret;
> @@ -327,7 +326,7 @@ void flushln(void)
>  		}
>  		if (obuf[i].c_char == '\0') {
>  			if (upln) {
> -				PRINT(CURS_RIGHT);
> +				print_line(CURS_RIGHT);

 Is it good name for the function? It does not print a line. It prints
 some chars without care about \n.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux