On Thu, Apr 28, 2011 at 04:56:36PM +0200, Werner Fink wrote:
> + if (options.chroot)
> + chroot(options.chroot);
> + if (options.chdir)
> + chdir(options.chdir);
is it correct to ignore chroot and chdir return values?
> + op->delay = atoi(optarg);
> + break;
[...]
> + op->nice = atoi(optarg);
> + break;
we usually use strtol_or_err() rather than atoi() from include/strutils.h
> + if ((op->flags & F_KEEPCFLAGS) == 0) {
> #ifdef CBAUD
> - termios.c_lflag &= ~CBAUD;
> + tp->c_lflag &= ~CBAUD;
> #endif
> - termios.c_cflag |= (B38400 | TTYDEF_CFLAG);
> + tp->c_cflag |= (B38400 | TTYDEF_CFLAG);
> + }
yes :-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
