On Tue, Apr 12, 2011 at 12:08, Karel Zak <kzak@xxxxxxxxxx> wrote:
>> - die(_("%s is mounted; will not make a filesystem here!"));
>> + errx(8, _("%s is mounted; will not make a filesystem here!"), device_name);
>
> Please, define and use EXIT_SOMETHING instead of the magic number '8'.
The disc-utils/mkfs.cramfs.c has
#define MKFS_OK 0 /* No errors */
#define MKFS_ERROR 8 /* Operational error */
#define MKFS_USAGE 16 /* Usage or syntax error */
and the return value 8 seems to be somehow special for mkfs* I wonder
if the definition of return values should be in mkfs.h
--
Sami Kerola
http://www.iki.fi/kerolasa/
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
