On Sat, Apr 09, 2011 at 10:17:58AM +0200, Olivier Menguà wrote: > I've noticed my patch has been committed in > 0a626987e244b6fa30c18cfa86d12cd80b3977e8. > Thanks. > > Le 29 mars 2011 01:39, Davidlohr Bueso <dave@xxxxxxx> a Ãcrit : > > > > On Sun, 2011-03-27 at 18:29 +0200, Olivier Menguà wrote: > > > -void *our_malloc(size_t size); > > > -void *our_realloc(void *ptr, size_t size); > > > > It would be nice to use our xalloc lib for stuff like this. > > Working on a patch for that. > However, note that xalloc error messages are not localized contrary to > the current implementation. Hmm.. it should be probably fixed. > > > -void print_help(void) > > > +static void print_help(void) > > > > Lately we've been standardizing this kind of things too. > > A real cleanup of this function would require to also merge the > multiple fputs() calls. This would have impact on localization. > What is the policy on changes having impact on localization? (Please, > add the answer to README.devel too). Don't care about localization, the strings will be translated before release. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com -- To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html