On Wed, 2011-04-06 at 10:36 +0200, Karel Zak wrote:
> On Thu, Mar 31, 2011 at 11:59:38AM -0300, Davidlohr Bueso wrote:
> > #define INODE_SIZE (sizeof(struct minix_inode))
...
>
> Oh.. Davidlohr, you forgot regression test ;-) What about to add
>
> mkfs.minix -{1,2,3}
>
> to tests/ts/minix/mkfs{1,2,3} ?
>
> It would be also nice to add MINIX3_SUPER_MAGIC to fsck.minix and
> print a warning that v3 is unsupported (yet?).
I had a feeling you would dislike the sloppy code (which was already a
part of mkfs.minix), so heck, let's invade it massively, like partx.
Like you mention, we need to go through several patches, which I will be
sending you over the next few days, this way it might be a bit easier to
merge.
Thanks,
Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
