Re: [PATCH 2/2] lscpu: fix threads-per-core calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 24, 2011 at 01:45:34PM +0100, Jan Engelhardt wrote:
> On a 24-thread/6-core SPARC T1, lscpu would wrongly output "5 threads
> per core".
> 
> It seems that the 6c T1 is simply an 8c T1 where 2c are disabled
> (offering a lesser model for a lower price, and all that marketing

LOL...

> fluff). So the machine description header of the 6c T1 reports 32
> threads, but only goes on to provide 24 elements thereafter, which is
> why Linux will report threads 24-31 as "offline". So far so good.
> 
> But lscpu would take the number of all (online and offline) threads
> (32) and divides it by the number of online cores (6), which yields an
> odd 5.33 threads/core.
> 
> Simply pick the number of online threads.

 OK.

> [Also, remove stray "(s)"s that do not belong there, and properly
> declare threads, avoid using "CPU" (which is an overloaded term
> meaning either thread, or package/NUMA node).]

avoid using "CPU(s)" is not backwardly compatible change :-( 

And I think that CPU is (maybe) overloaded term, but pretty commonly
used and all users are able to understand what it means.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux