Re: [PATCH] umount: allow non-root umount of FUSE even if not in fstab

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 28, 2011 at 04:04:56PM +0200, Petr Uzel wrote:
> I have to admit that I don't like it very much, because:

I don't like it too :-)

> - it complicates umount
> - duplicates code from fusermount
> - should (???) be implemented using umount helpers

[...]

> +		/* If this is fuse-based filesystem, allow user unmount even
> +		 * if the FS is not in fstab.
> +		 *
> +		 * Based on fusermount code. */
> +		if (strcmp(mc->m.mnt_type, "fuse") == 0 ||
> +		    strcmp(mc->m.mnt_type, "fuseblk") == 0 ||
> +		    strncmp(mc->m.mnt_type, "fuse.", 5) == 0 ||
> +		    strncmp(mc->m.mnt_type, "fuseblk.", 8) == 0) {

Wouldn't be better to always call /sbin/umount.fuse for non-roots (except
umount -i)? 

I believe more and more that we need something like

    /etc/mount.d/{fuse,foo,...}.conf

where we can define such behavior for some filesystems.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux