Re: [PATCH 2/4] logger: support long options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 24, 2011 at 08:16:40PM +0100, Sami Kerola wrote:
>  	char *usock = NULL;
>  	char *udpserver = NULL;
>  	int LogSock = -1;
> +	long tmpport;
> +
> +	struct option longopts[] = {

 Please, next time use "static const" to store the array in .rodata section. 

> +		{ "id",		no_argument,	    0, 'i' },
> +		{ "stderr",	no_argument,	    0, 's' },
> +		{ "file",	required_argument,  0, 'f' },
> +		{ "priority",	required_argument,  0, 'p' },
> +		{ "tag",	required_argument,  0, 't' },
> +		{ "socket",	required_argument,  0, 'u' },
> +		{ "udp",	no_argument,	    0, 'd' },
> +		{ "server",	required_argument,  0, 'n' },
> +		{ "port",	required_argument,  0, 'P' },
> +		{ "version",	no_argument,	    0, 'V' },
> +		{ "help",	no_argument,	    0, 'h' },
> +		{ NULL,		0, 0, 0 }
> +	};

 Applied, thanks.

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux