On Sat, Feb 12, 2011 at 03:36:26PM +0100, Sami Kerola wrote:
> See attachment for fixed patch; it is less intrusive.
Applied, thanks.
> I realized I am not good enough in python to do fixes as complex I
> tried initially.
IMHO you're trying to change too many things in one patch. Try
smaller patches rather than one huge.
For example:
> Usage output screen got to be completely rewrote. Aim is to
1.patch
> assist user to determe which switches to use without reading
> manual page. The change also introduced new option to see command
> version.
2.patch
> Determination if the executable name is `page' is now easy to see
> in source, and effect of using the name is mentioned in manual
> page.
3.patch
> Rest of the change is trivial; exit values to compiler warning
4.patch
> removals, magic constants to preprocessor definitions,
5.patch
> symbolic exit values, comment pretty printing and #endif markups.
6.patch
.. so next time 6 patches rather than 1 huge ;-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
