On Wed, Jan 19, 2011 at 10:51:52AM +0100, Karel Zak wrote:
> On Wed, Jan 19, 2011 at 09:58:01AM +0100, Sami Kerola wrote:
> > In the c.h the ignore_result marco caused few ISO C forbids
> > braced-groups within expressions warnings.
>
> Do we really need to support non-gcc compilers?
>
> > Rest of the fixes are trivial, such as missed initializer, unused
> > parameter and comparisions with signed and unsigned integers, and
> > one EXIT_* fix.
> >
> > Signed-off-by: Sami Kerola <kerolasa@xxxxxx>
> > ---
> > include/c.h | 2 +-
> > login-utils/agetty.c | 15 ++++++++-------
> > 2 files changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/c.h b/include/c.h
> > index cfee616..96dbd10 100644
> > --- a/include/c.h
> > +++ b/include/c.h
> > @@ -62,7 +62,7 @@
> > _max1 > _max2 ? _max1 : _max2; })
> > #endif
> >
> > -#define ignore_result(x) ({ typeof(x) __dummy = (x); (void) __dummy; })
> > +#define ignore_result(x) ((void) (x))
>
> This is stupid change.
>
> http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/3784
>
> What about:
>
> #ifndef __GCC__
> # define ignore_result(x) ((void) (x))
> #else
> # #define ignore_result(x) ({ typeof(x) __dummy = (x); (void) __dummy; })
> #endif
>
Should be resolved now.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
