On Wednesday, February 02, 2011 09:22:53 Karel Zak wrote:
> On Wed, Feb 02, 2011 at 01:52:28PM +0100, Petr Uzel wrote:
> > On Tue, Feb 01, 2011 at 08:11:43PM -0500, Mike Frysinger wrote:
> > > somewhat related, this code really should read something like:
> > > create_daemon()
> > > {
> > > uid_t euid;
> > >
> > > if (daemon(0, 0))
> > > die("daemon");
> > >
> > > euid = geteuid();
> > > if (setreuid(euid, euid) < 0)
> > > die("setreuid");
> > > }
> >
> > This seems to be a nice simplification. I'm just wondering - would
> > that require checking for daemon(3) in configure.ac?
>
> We already use daemon(3) in sys-utils/ldattach.c and nobody
> complains (but I have doubts it's available on Solaris).
right ... i would think if we want to go the replacement route, we'd implement
a daemon() replacement in common code. and make people who care about those
systems implement it ;).
> It would be better to do this change after v2.19 release. We have
> people who care about libblkid and libuuid portability, it's not fair
> to modify the code now.
that's fine ... although this is the uuid daemon and not part of libuuid ;)
-mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
