Re: [PATCH 2/3] fsck.c: use xmalloc, warn & err and new usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 19, 2011 at 09:58:02AM +0100, Sami Kerola wrote:
> All compler errors reported by -Wall -Wextra -pedantic are fixed.

 Do we really need -pedantic?

> The patch also makes fsck to use xalloc instead of it's own
> malloc. That will make fsck to exit, which could be good thing,
> at sections where it previously did not.

 It's not so simple, fsck has documented exit codes.

 I have modified xalloc.h, so you can overwrite the default
 EXIT_FAILURE by 

    #define XALLOC_EXIT_CODE   <foo>
    #include xalloc.h

 (you don't have to resend the patch).

> Almost all print outs where touched, where various printfs where
> converted to warn or err messages.
> 
> Finally theres a fix to counter wrap bug that could (very
> unlikely) manifest itself if an user specifies same flag exactly
> UINT_MAX times.

 I'll apply this patch after v2.19 release.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux