On Tue, Jan 18, 2011 at 12:06:58PM -0300, Davidlohr Bueso wrote:
> On Tue, 2011-01-18 at 15:36 +0100, Yann Droneaud wrote:
> > Le jeudi 06 janvier 2011 Ã 09:08 -0300, Davidlohr Bueso a Ãcrit :
> > > +static void __attribute__((__noreturn__)) usage()
> >
> > Please do not declare function without parameter like this.
> > Such definition allows any number of argument to be given to the
> > function call.
>
> Not that it matters much in this case, but yes it's good practice to do
> so, missed it this time. Care to send a patch? You might also want to
> look at text-util/col.c
Fixed.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
