Re: [PATCH 1/3] agetty.c and c.h: supress compiler warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Jan 2011, Sami Kerola wrote:

In the c.h the ignore_result marco caused few ISO C forbids
braced-groups within expressions warnings.

Rest of the fixes are trivial, such as missed initializer, unused
parameter and comparisions with signed and unsigned integers, and
one EXIT_* fix.

Signed-off-by: Sami Kerola <kerolasa@xxxxxx>

--- a/login-utils/agetty.c
+++ b/login-utils/agetty.c

@@ -615,10 +617,9 @@ update_utmp(line)

/* open_tty - set up tty as standard { input, output, error } */
void
-open_tty(tty, tp, local)
+open_tty(tty, tp)
     char   *tty;
     struct termios *tp;
-     int    local;
{

Isn't that a good opportunity to get rid of the old-style (K&R) function
definitions and replace them by ANSI C ones?

Regards
Peter Breitenlohner <peb@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux