Re: [PATCH 2/11] agetty: Use EXIT_* and add noreturn attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 01, 2010 at 05:17:25PM +0100, Marek Polacek wrote:
> Signed-off-by: Marek Polacek <mmpolacek@xxxxxxxxx>
> ---
>  login-utils/agetty.c |   25 ++++++++++++-------------
>  1 files changed, 12 insertions(+), 13 deletions(-)

 Applied, thanks. The agetty code is horrible... there is necessary
 refactoring.

> 
> -void
> -usage()
> +void __attribute__((__noreturn__)) usage()
>  {
>      fprintf(stderr, _("Usage: %s [-8hiLmsUw] [-l login_program] [-t
> timeout] [-I initstring] [-H login_host] baud_rate,... line
> [termtype]\nor\t[-hiLmw] [-l login_program] [-t timeout] [-I initstring]
> [-H login_host] line baud_rate,... [termtype]\n"), progname);

 It seems you mail client does not like this line ;-)

 patch: **** malformed patch at line 152: timeout] [-I initstring] [-H
 login_host] baud_rate,... line

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux