Re: [PATCH] fdisk: properly handle SIGINTs for better user control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 15, 2010 at 08:52:46AM -0300, Davidlohr Bueso wrote:
> +static void
> +sighand(int sig) {
> +	if (sig == SIGINT)
> +		is_mainmenu() ? _exit(EXIT_SUCCESS) : main_menu();
                                              ^^^^^^^^^^
> +}

 So you moved whole fdisk to signal handler, really?

 The fdisk command usually wait on read_int() and read_char(), you
 have to care about these functions and properly return to the top
 level menu or xmenu.

 Anyway, this is not important issue. All our fdisks need refactoring
 (or libfdisk ?)...

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux