Re: [PATCH] mount: fix memory leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 18, 2010 at 05:14:53PM +0200, Petr Uzel wrote:
> ---
>  mount/mount.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/mount/mount.c b/mount/mount.c
> index 2be43ab..aa68237 100644
> --- a/mount/mount.c
> +++ b/mount/mount.c
> @@ -1460,13 +1460,15 @@ try_mount_one (const char *spec0, const char *node0, const char *types0,
>        /* Mount succeeded, report this (if verbose) and write mtab entry.  */
>  
>        if (!(mounttype & MS_PROPAGATION)) {
> +	      char *mtab_opts = fix_opts_string (flags & ~MS_NOMTAB, extra_opts, user);
>  	      update_mtab_entry(loop ? loopfile : spec,
>  			canonicalized_node,
>  			types ? types : "unknown",
> -			fix_opts_string (flags & ~MS_NOMTAB, extra_opts, user),
> +			mtab_opts,
>  			flags,
>  			freq,
>  			pass);
> +	      free (mtab_opts);
>        }

 Applied, thanks. There is probably many leaks. I hope this kind of
 problems will be resolved in libmount.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux