Re: blkid_probe_is_tiny change in 2.17.1 breaks nash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le mercredi 10 mars 2010 à 04:58 +0100, Pascal Terjan a écrit :
> Le mercredi 10 mars 2010 à 04:41 +0100, Pascal Terjan a écrit :
> > Le mercredi 10 mars 2010 à 04:13 +0100, Pascal Terjan a écrit :
> > > Le mercredi 10 mars 2010 à 00:12 +0100, Karel Zak a écrit :
> > > > On Tue, Mar 09, 2010 at 08:51:16PM +0100, Pascal Terjan wrote:
> > > > > Hi
> > > > > 
> > > > > nash (from mkinitrd) no longer finds swap devices since we updated
> > > > > libblkid to 2.17.1
> > > > > 
> > > > > It seems that size is always 0 in blkid_probe_set_device which means
> > > > > that later blkid_probe_is_tiny is always true.
> > > > 
> > > >  I don't think so. The code calls stat() or blkdev_get_size() to get
> > > >  size if the size argument is zero. 
> > 
> > blkdev_get_size seems to expect an unsigned long long from BLKGETSIZE64
> > while it works on size_t despite its name
> 
> It's 5am so I will get back to bed without exactly understanding the
> issue, just wanted to add that I just tested and size is not 0 on
> x86_64, only on my i586 machines

OK, so there are 2 bugs:

- size (and offset) is printed with %zd instead of %llu 
- BLKID_TINY_DEV flag is not reset in blkid_probe_set_device

--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux