Re: [PATCH 2/2] cfdisk: swap order of '[Help]' and '[New]' items on menu for non allocated space.'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 Hi,

 why we need this change? Wouldn't it be better to use [New] as a
 default item in the menu rather than change the order of items?

    Karel

On Wed, Feb 10, 2010 at 12:42:27PM +0100, Francesco Cosoleto wrote:
> Signed-off-by: Francesco Cosoleto <cosoleto@xxxxxxxxx>
> ---
>  fdisk/cfdisk.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fdisk/cfdisk.c b/fdisk/cfdisk.c
> index f871cc4..7c0275d 100644
> --- a/fdisk/cfdisk.c
> +++ b/fdisk/cfdisk.c
> @@ -2590,9 +2590,9 @@ do_curses_fdisk(void) {
>          { 'b', N_("Bootable"), N_("Toggle bootable flag of the current partition") },
>          { 'd', N_("Delete"), N_("Delete the current partition") },
>          { 'g', N_("Geometry"), N_("Change disk geometry (experts only)") },
> +        { 'n', N_("New"), N_("Create new partition from free space") },
>          { 'h', N_("Help"), N_("Print help screen") },
>          { 'm', N_("Maximize"), N_("Maximize disk usage of the current partition (experts only)") },
> -        { 'n', N_("New"), N_("Create new partition from free space") },
>          { 'p', N_("Print"), N_("Print partition table to the screen or to a file") },
>          { 'q', N_("Quit"), N_("Quit program without writing partition table") },
>          { 't', N_("Type"), N_("Change the filesystem type (DOS, Linux, OS/2 and so on)") },
> @@ -2625,7 +2625,7 @@ do_curses_fdisk(void) {
>  	(void)draw_cursor(0);
>  
>  	if (p_info[cur_part].id == FREE_SPACE) {
> -	    s = ((opentype == O_RDWR) ? "hnpquW" : "hnpqu");
> +	    s = ((opentype == O_RDWR) ? "nhpquW" : "nhpqu");
>  	    command = menuSelect(COMMAND_LINE_Y, COMMAND_LINE_X, menuMain, 10,
>  	        s, MENU_HORIZ | MENU_BUTTON | MENU_ACCEPT_OTHERS, 0);
>  	} else if (p_info[cur_part].id > 0) {
> -- 
> 1.6.6.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux