2010/1/14 Karel Zak <kzak@xxxxxxxxxx>:
> On Thu, Jan 14, 2010 at 07:08:52PM +0100, Jeroen Oortwijn wrote:
>> 2010/1/14 Jeroen Oortwijn <oortwijn@xxxxxxxxx>:
>> > + .magics = {
>> > + { .magic = "1SFB", .len = 4, .sboff = 0x220 },
>> > + { NULL }
>> > + }
>>
>> The superblock of the Be File System contains three magic numbers and
>> I initially added all three of them to .magics. However, when testing
>> the code I realised that libblkid checks if the superblock contains at
>> least one of these three instead of (what I thought it would do)
>
> Yes. The magic string is the first (basic) level of the probing.
I noticed something strange happening with the basic probing: an
extended partition on one of my hard-disks is recognised as having a
befs file system.
I think this is because that partition was previously a primary
partition formatted as befs. During install of Ubuntu, that partition
was converted to an extended partition (containing two logical
volumes) by the Ubuntu installer, but it apparently left the befs
superblock untouched.
Now, I think this should be fixed in libblkid and not in the befs
module: when it encounters an extended partition, it should not probe
for a file system on it as it couldn't contain one (it's only 1024
bytes). But I don't have a lot of knowledge in that area, so maybe it
should be fixed in the probing function of the befs module instead?
And if so, how would I do that?
- Jeroen
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
