Re: [PATCH] mount: add a search path for mount helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 15 January 2010 06:47:24 Karel Zak wrote:
> On Thu, Jan 14, 2010 at 10:42:51PM -0500, Mike Frysinger wrote:
> > --- a/mount/mount.c
> > +++ b/mount/mount.c
> > @@ -631,6 +631,8 @@ do_mount (struct mountargs *args, int *special, int
> > *status) { return ret;
> >  }
> >
> > +#define MOUNT_SEARCH_PATH "/sbin:/usr/sbin"
> 
>  This should be defined by
> 
>     ./configure --with-mount-path=<list>
> 
>  where the default is "/sbin". Is it acceptable compromise?

why dont we unify these random hardcoded paths.  mkfs has one, fsck has a 
similar one, and mount has a completely different one.  so for the configure 
options, we can do:
	--with-fs-paths-default=paths    default search path for fs helpers
			default=/sbin:/sbin/fs.d:/sbin/fs:/etc/fs:/etc
	--with-fs-paths-extra=paths    extra search paths for fs helpers
			default=<none>

since in my case i merely want to append /usr/sbin to the default

also, mkfs searches via exec while fsck and mount explicitly parse the paths, 
so the latter two can easily be unified here.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux