On 01/12/2010 01:00 PM, Adam Jackson wrote:
> On Sat, 2010-01-09 at 01:05 +0100, Guillem Jover wrote:
>
>>> + if (!*loop) {
>>> + struct stat st_buf;
>>> + stat(*spec, &st_buf);
>>> + *loop = S_ISREG(st_buf.st_mode);
>>
>> Shouldn't you check if stat was successful before using st_buf?
>
> Yeah, I suppose. I think we've already stat'd the file once before
> this, so I doubt it'd ever fail, but might as well be sure.
It could fail if the file is moved out from underneath.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
