On Tuesday 13 October 2009 04:15:46 Karel Zak wrote: > > On Monday 12 October 2009 21:19:27 Christoph Hellwig wrote: > > > FYI: this breaks xfstests as it expects mkfs.* only in /sbin. Wouldn't > > > be surprised if others tools do the same. > > the other example is /sbin/mkfs, this tool uses > > "PATH=/sbin:/sbin/fs:/sbin/fs.d:/etc/fs:/etc" well, this is info is a bit limited. mkfs will prepend this to the current $PATH, so generally nothing is broken that isnt already broken (i.e. a system with a reduced PATH in the env). regardless of anything else, i think the default search PATH should include /usr/sbin and maybe /usr/local/sbin (especially since it uses such odd paths like /sbin/fs*/). mkfs is also a little weird here. i'd expect it to monkey with the PATH only if the current PATH was insufficient. i.e. it should be appending the PATH instead of prepending it. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
