On Tuesday 13 October 2009 05:38:01 Karel Zak wrote: > On Tue, Oct 13, 2009 at 05:18:55AM -0400, Mike Frysinger wrote: > > On Tuesday 13 October 2009 04:15:46 Karel Zak wrote: > > > On Mon, Oct 12, 2009 at 10:52:31PM -0400, Mike Frysinger wrote: > > > > On Monday 12 October 2009 21:19:27 Christoph Hellwig wrote: > > > > > On Mon, Oct 12, 2009 at 03:26:30PM +0200, Karel Zak wrote: > > > > > > On Sat, Oct 10, 2009 at 08:07:16PM -0400, Mike Frysinger wrote: > > > > > > > The bfs/cramfs/minix rarely (if ever?) are used for root > > > > > > > filesystems, so it doesn't make much sense to keep them in the > > > > > > > root partition. Move them to /usr by default. > > > > > > > > > > > > Good idea. Applied, thanks. > > > > > > this was too optimistic... > > > > > > > > FYI: this breaks xfstests as it expects mkfs.* only in /sbin. > > > > > Wouldn't be surprised if others tools do the same. > > > > > > the other example is /sbin/mkfs, this tool uses > > > > > > "PATH=/sbin:/sbin/fs:/sbin/fs.d:/etc/fs:/etc" > > > > you're going to fix it up or should i send a patch ? > > Bad question :-) > > The question is: do we really expect mkfs.<type> and > fsck.<type> tools in /usr/sbin? i think you're asking the wrong question. should we cater to applications that only search /sbin ? i obviously dont think so. ignoring the simple / vs /usr issue, such programs already break with some default distro packages, they break with packages people install themselves into /usr/local, and they break with user-specific packages in $HOME. i dont really think it's all that difficult to add a PATH search to your code. > > > > it's already been broken as not all packages install their mkfs/fsck > > > > into /sbin. package PATH assumptions are always invalid anyways. > > > > > > Well, I see /usr/sbin/mkfs.gfs2 only. > > > > i see jffs2, ubifs, msdos, ntfs, vfat > > Fedora has msdos, ntfs, vfat in /sbin (and I don't have installed > jffs2, ubifs). well, install mtd-utils and you'll get jffs2/ubifs a quick search on Debian shows also btrfs/cpm/gfs/gfs2/lustre is in /usr, although btrfs will probably move over the years as people transition to using that for their rootfs. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
