On Monday 12 October 2009 09:56:15 Karel Zak wrote:
> On Sat, Oct 10, 2009 at 08:07:15PM -0400, Mike Frysinger wrote:
> > The current code triggers this automake warning:
> > shlibs/blkid/docs/Makefile.am:88: EXTRA_DIST must be set with `=' before
> > using `+='
> >
> > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> > ---
> > shlibs/blkid/docs/Makefile.am | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/shlibs/blkid/docs/Makefile.am
> > b/shlibs/blkid/docs/Makefile.am index b8ea54e..ecebd2c 100644
> > --- a/shlibs/blkid/docs/Makefile.am
> > +++ b/shlibs/blkid/docs/Makefile.am
> > @@ -84,8 +84,8 @@ GTKDOC_LIBS=
> > include $(top_srcdir)/gtk-doc.make
> >
> > # Other files to distribute
> > -# e.g. EXTRA_DIST += version.xml.in
> > -EXTRA_DIST += version.xml.in
> > +# e.g. EXTRA_DIST = version.xml.in
> > +EXTRA_DIST = version.xml.in
>
> This is bad idea. The standard gtk-doc.make file has EXTRA_DIST=.
ah, sorry about that
> It means this your patch works only with your fake gtk-doc.make (from
> the previous patch) on systems without gtk-doc. It won't work on
> systems with gtk-doc.
>
> I have committed gtk-doc.{make,m4} to the repository. I didn't found
> any other sane way how to resolve all possible problems around
> gtk-doc.
that seems to work for me (tested git master), thanks !
-mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
