Re: [PATCH] libblkid: Erroneous detection of FAT partition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karel Zak wrote:
> On Thu, Oct 01, 2009 at 09:28:28PM +0200, Lawrence Rust wrote:
>>>> +	/* Old floppies have a valid MBR signature */
>>>> +	if (ms->ms_pmagic[0] != 0x55 || ms->ms_pmagic[1] != 0xAA)
>>>> +		return 1;
>>>  there was a wrong comment in msdos_super_block, the ms_pmagic is at
>>>  0xef offset. The MBR signature is at 0x1ef.
>> Well spotted, but I believe that we are both mistaken.  This link:
>> http://support.microsoft.com/kb/140418
> 
>  Applied (but without the STATIC_ASSERT), thanks.

Yes, that one was a copy of the microsoft C_ASSERT macro,
but it doesn't assert on non constant expressions.

For alternatives see:
http://www.pixelbeat.org/programming/gcc/static_assert.html

cheers,
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux