Re: [PATCH] blkid: add support to the -w option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 04, 2009 at 12:00:08PM +0800, Peng Tao wrote:
> blkid -w should write an alternative cache file but it is not implemented.
> The patch addresses this issue by adding a new interface to cache.c to set
> the alternative cache filename.
> 
> Addresses-Launchpad-bug: #316322
> 
> Signed-off-by: Peng Tao <bergwolf@xxxxxxxxx>
> ---
>  misc-utils/blkid.c         |    1 +
>  shlibs/blkid/src/blkid.h   |    1 +
>  shlibs/blkid/src/blkid.sym |    1 +
>  shlibs/blkid/src/cache.c   |   21 +++++++++++++++++++++
>  4 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/misc-utils/blkid.c b/misc-utils/blkid.c
> index e9622c3..b822b66 100644
> --- a/misc-utils/blkid.c
> +++ b/misc-utils/blkid.c
> @@ -636,6 +636,7 @@ int main(int argc, char **argv)
>  			err = 0;
>  		}
>  	}
> +	blkid_set_cachefile(cache, write);

 Ted, do you have any objection to extend the high-level API with
 blkid_set_cachefile()? From my point of view this request makes
 sense. It seems the patch is waiting in your queue to e2fsprogs.
 
 The ideal solution would be to have the 'filename' argument in the
 blkid_put_cache() (we have it for blkid_get_cache()).  Unfortunately,
 this solution is not backwardly compatible. The blkid_set_cachefile()
 looks less invasive.

    Karel
-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux