[PATCH] libblkid: fix topology iinformation values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Looks like the topology values returned are being
inflated by x 512, but the kernel reports them in bytes;
no need for the multiplication, just return the value as-is.

With the patch it all matches:

# mdadm -D /dev/md0  | grep Chunk
     Chunk Size : 64K
# cat /sys/devices/virtual/block/md0/queue/minimum_io_size 
65536
# blkid/samples/topology /dev/md0
----- NAME=value interface (values: 0):
	MINIMUM_IO_SIZE = 65536
	OPTIMAL_IO_SIZE = 131072
----- binary interface:
alignment offset : 0
minimum io size  : 65536
optimal io size  : 131072

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

iff --git a/shlibs/blkid/src/topology/topology.c b/shlibs/blkid/src/topology/topology.c
index 8ebd5b0..b424054 100644
--- a/shlibs/blkid/src/topology/topology.c
+++ b/shlibs/blkid/src/topology/topology.c
@@ -160,7 +160,7 @@ dev_topology_attribute(const char *attribute, dev_t dev, dev_t *primary)
 	DBG(DEBUG_LOWPROBE,
 		printf("topology: attribute %s = %lu (sectors)\n", attribute, result));
 
-	return result * DEFAULT_SECTOR_SIZE;
+	return result;
 err:
 	if (fp)
 		fclose(fp);

--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux