On Mon, Jul 20, 2009 at 03:16:28PM +0200, Karel Zak wrote: > > Hi Robin, > > On Wed, Jul 15, 2009 at 09:33:22AM -0500, Robin Holt wrote: > > This patch introduces two new options (actually three). > > I spent a moment with the patch, and I found few problems: > > - the applications that prepare output according to the terminal size > (e.g. ps aux) will produce too long lines. It seems that workaround > is to change size (-30 columns) of the slave terminal by TIOCSWINSZ. > > - interactive mode (without -c) does not work properly > > Script started, file is typescript > 0.000008 ( 0.000008)| > nb:~$ date > 2.602039 ( 0.272087)| Mon Jul 20 14:55:44 CEST 2009 > 2.605886 ( 0.003847)| > nb:~$ exit > Script done, file is typescript > > I guess we expect the timestamps and prompt ("nb:~$") on the same line. > > And finally, the code in the patch could be refactored (see my attempt > below). > > Sorry, but from my point of view the patch still looks like a hack. Not > sure if we really need it. Am I correct in assuming that this patch is dead entirely? Robin -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html