Hi Zdenek,
On Fri, May 22, 2009 at 11:21:52PM +0200, Zdenek Behan wrote:
> As announced, the first patch is rather large. It splits fdisk.c into:
> fdisk.c,util.c,diskutil.c,fdiskdoslabel.c (and appropriate headers).
> Since the original code was a huge hairball closely bound together,
> picking out individual hair and putting them on separate heaps has to be
> a bit messy. I tried to keep all function semantics, and merely kick
> things around. While not always 100% possible, with some dirty help, I
> slowly ended up at this patch.
>
> Sent as bz2 attachment because of size.
Hmm... the patch has 4509 lines. That's impossible to review this
mess. Do you really need to split whole fdisk.c into three files by
*one huge patch*? I don't think so.
#1 patch -- create util.c, move one function (or more small functions)
#2 patch -- move another function to util.c
.
.
#n patch -- move GPT stuff from gpt.c to fdiskgptlabel.c
#n+1 patch -- move gpt.h to fdiskgptlabel.h
.
.
Please. It's important to have usable and traceable history of
changes in git repository.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
