On Mon, May 25, 2009 at 12:24:46PM +0100, John Keeping wrote: >date_child_fp is opened by popen, so should be closed with pclose. > >Signed-off-by: John Keeping <john.keeping@xxxxxxxxxxx> Good catch! Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> >--- > hwclock/hwclock.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/hwclock/hwclock.c b/hwclock/hwclock.c >index 11c606d..571d63f 100644 >--- a/hwclock/hwclock.c >+++ b/hwclock/hwclock.c >@@ -676,7 +676,7 @@ interpret_date_string(const char *date_opt, time_t * const time_p) { > date_opt, (long) *time_p); > } > } >- fclose(date_child_fp); >+ pclose(date_child_fp); > > return retcode; > } >-- >1.6.3.1 > >-- >To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in >the body of a message to majordomo@xxxxxxxxxxxxxxx >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html