On Tue, Apr 28, 2009 at 12:35:31AM -0400, Mike Frysinger wrote: > looking in git shows that this bug report hasnt been sent along ... > http://bugs.debian.org/511161 Fixed. I'd like to review all fdisk/ code in the next release. Almost all [cs]fdisk bug reports are about data types. Some parts of code also need refactoring, we don't have regression test, ... Volunteers? ;-) > the propose patch looks pretty straight forward to me (although i'd wonder why > the source code is using "long long" in these places instead of "off_t" ...) Good point. The "long long" is a generic problem in fdisk/ code (something is an original util-linux code, something is from one very old Suse patch). I have added a note about "off_t" to TODO file. Now is probably too late for so invasive patches. Thanks Mike! Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
