> In my mailbox are Andi's patches that implement "little endian only". > Unfortunately, it seems that kernel part of Andi's work has been > never committed. > > http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/933 > A kernel patch may also not be applicable for usage in existing systems that cannot upgrade their kernel. > Cannot we use generic macros from include/bitopt.h? I'd like to avoid > duplicates. > > The rest of the patch seems good on the first glance. > > [Frankly, I hate long function names -- e.g "inode_endianness_from_host". > Why not "inode_from_host" ? ... ;-) ] > Please see the updated patch (I'm sending it in a separate message), I've changed the function names, and used the swab32 function from include/bitops.h. > Yes, cramfs is an endianness dependent FS. So, your patch makes > sense, but I'd like to see some regression tests before we apply such > invasive patch. > About the regression tests, would a script that creates\extracts a cramfs image be acceptable? This script would test all endianness options using the new -N parameter, and will also test the existing behavior, without the -N parameter. Any addition tests you would like see? Roy Peled -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
