[PATCH] Segmentation fault with INCLUDE_FS_TESTS and no -x option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The current implementation causes a segmentation fault if
INCLUDE_FS_TESTS is defined, but the -x option is not specified.

The error is caused by the extract_dir variable being null.
This simple patch assigns a dummy value to extract_dir,
so that the filesystem tests can continue without error.

Signed-off-by: Roy Peled <the.roy.peled@xxxxxxxxx>

---
diff -urNp util-linux-ng-2.14.1.org/disk-utils/fsck.cramfs.c util-linux-ng-2.14.1/disk-utils/fsck.cramfs.c
--- util-linux-ng-2.14.1.org/disk-utils/fsck.cramfs.c	2008-11-13 05:57:01.000000000 +0200
+++ util-linux-ng-2.14.1/disk-utils/fsck.cramfs.c	2008-11-18 10:19:31.000000000 +0200
@@ -68,7 +68,7 @@ struct cramfs_super super;	/* just find 
 static int cramfs_is_big_endian = 0;	/* source is big endian */
 static int opt_verbose = 0;	/* 1 = verbose (-v), 2+ = very verbose (-vv) */
 
-char *extract_dir = NULL;	/* extraction directory (-x) */
+char *extract_dir = "/dummy";	/* extraction directory (-x). Dummy value in case opt_extract is false */
 
 /* Exit codes used by fsck-type programs */
 #define FSCK_OK          0	/* No errors */
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux