Re: [PATCH] swapon: add swap detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 05, 2008 at 06:33:57PM +0100, Matthias Koenig wrote:
> >  .. one question comes to mind: is it safe? Are you really sure that
> >  there is a swap space on the device? Maybe I'm too paranoid, but I
> >  I think it would be better to ask libblkid/volume_id.
> 
> Yes, being paranoid was the reason for Olaf to insist on the size check.
> Only if 1. the magic is found *and* 2. the size is valid, then we accept
> this as valid swap space. I think this is more safe then current

 Yes, you are right. Ignore this my note, you still need to read the swap
 header for pagesize, etc.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux