On Sat, Nov 01, 2008 at 07:51:56PM +0100, Olaf Hering wrote: > On Fri, Oct 31, Karel Zak wrote: > > > I think it would be better to ask libblkid/volume_id. hmm... this is useless idea. The problem is that mkswap does not zeroize (zap) the first block on the device. It means for example libblkid is not fully reliable for swap detection. We need to fix this mkswap problem. > libvolume_id has no size checks, for any "detected" filesystems. > Thats not correct. So it can not be used. > > A swap partition/file is not just a string at a certain offset, > its also the size in blocks in the metadata. > Only if both match, it could be swap. Send patch. We need a reliable swap detection in libblkid/volume_id. Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html