Re: [PATCH] namei: users and groups printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 21, 2008 at 08:44:21AM +0200, Sami Kerola wrote:
> namei: users and groups printing

 Nice idea. Unfortunately, namei(1) code does not seem ready for
 this change.

> +	if(username == NULL) {
> +		printf(" %8d", (int)stb->st_uid);
> +	} else {
> +		printf(" %8s", username->pw_name);
> +	}

 The fixed width of username/groupname looks very oddly. I think we
 should follow ls(1) that uses dynamic width of the column.

 I'll rewrite the namei.c and apply your patch later. Thanks.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux