Re: util-linux-ng: mount, umount and swapon need libuuid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 29, 2008 at 10:43:02AM +0200, Karel Zak wrote:
> On Fri, Aug 29, 2008 at 10:05:41AM +0200, Robert Schwebel wrote:
> > Configure checks for libuuid and makes it mandatory, but the
> > functions
>
>  I don't think that libuuid is mandatory, it's optional.

Thanks, I had a closer look and you are right, the patch needs to be
different.

Here is the error output:

arm-iwmmx-linux-gnueabi-gcc -std=gnu99  -fsigned-char -g -O2 -L/somewhere/sysroot-target/lib -L/sysroot-target/usr/lib
-Wl,-rpath-link -Wl,/somewhere/sysroot-target/usr/lib
-o mount mount-mount.o mount-fstab.o mount-mount_mntent.o
mount-getusername.o mount-lomount.o mount-sundries.o mount-xmalloc.o
mount-realpath.o mount-fsprobe.o mount-fsprobe_blkid.o   mount-env.o
mount-linux_version.o mount-blkdev.o  mount-setproctitle.o -lblkid
/somewhere/sysroot-target/usr/lib/libblkid.a(probe.o):
In function `set_uuid':
/somewhere/build-target/e2fsprogs-1.40.8/lib/blkid/probe.c:130:
undefined reference to `uuid_is_null'

So the thing is that, when uuid support is detected, libblkid.a wants to
use it, mount wants to link against it and it is being sucked in.

> > that use it forget to link against it. Not sure if the patch below is
> [...]
> > +mount_LDADD = $(LDADD_common) -luuid
> > +umount_LDADD = $(LDADD_common) -luuid
> > +swapon_LDADD = $(LDADD_common) -luuid
> 
>  Why do you think that mount,umount and swapon use stuff from libuuid?
> 
>  The libuuid is required by mkswap only.

Yup, side effect, see above. I'll invent a better patch ...

rsc
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux