Hi Benno,
On Fri, Aug 15, 2008 at 12:21:58AM +0200, Benno Schulenberg wrote:
> Currently the output of 'ipcs -m' is slightly misaligned:
>
> ------ Shared Memory Segments --------
> key shmid owner perms bytes nattch status
> 0x00000000 131072 ben 600 196608 2 dest
> 0x00000000 98305 ben 600 393216 2 dest
>
> The first patch (to follow) fixes that by adding a space before the
> perms data column. It also correctly aligns the output of 'ipcs -mt'
> by removing a leading space from the "attached" column.
>
> (I'm unsure though whether the second hunk is correct, and whether the
> field widening in the third hunk is needed and correct.)
it would be better to fix the headers alignment than touch the data.
It's possible that people use ipcs in their scripts and we shouldn't
change the positions of the data columns.
> The second patch removes the gexttextization of the formatting strings
> for all ipcs table headers. There's no point in allowing translators
> to change this formatting when they can't change the formatting of the
> data itself.
Yes, I agree. I'll commit the patch tomorrow or so. Thanks.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
