On Fri, Aug 08, 2008 at 11:09:25PM +0200, Tomasz Chmielewski wrote:
> Karel Zak schrieb:
>> Yeah, our synchronize_to_clock_tick() :-)
>>
>>
>> hwclock/rtc.c, busywait_for_rtc_clock_tick():
>>
>> for (i = 0;
>> (rc = do_rtc_read_ioctl(rtc_fd, &nowtime)) == 0
>> && start_time.tm_sec == nowtime.tm_sec;
>> i++)
>> if (i >= 1000000) {
>> fprintf(stderr, _("Timed out waiting for time change.\n"));
>> return 2;
>> }
>
> What about waiting here in seconds rather than to make these loops?
>
> i.e., wait 10 or 30 seconds, if it is more than that, bail out?
Probably yes.
> But would it solve the issue, really?
Yes, that's core of the problem. But we also need to remove some return
code checks from manipulate_clock(). These checks are unnecessary,
because there is hclock_valid boolean... (this is my bug.)
> hwclock from busybox is able to show the clock (Tue Nov 30 00:00:00
> 1999 0.000000) and also set it; the above seems to exit only - and
> still, we're not able to show or set the clock?
I'll send a patch ASAP.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
