- Bogus if test means one message is never produced. - Avoid needless passing of a global variable (debug). The --test option flag ought to be a global as well (and perhaps -n/--dry-run). Signed-off-by: Kalev Soikonen <ksop@xxxxxx> --- hwclock/hwclock.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hwclock/hwclock.c b/hwclock/hwclock.c index 1fb0058..619ff79 100644 --- a/hwclock/hwclock.c +++ b/hwclock/hwclock.c @@ -851,8 +851,7 @@ calculate_adjustment(const double factor const double not_adjusted, const time_t systime, int *adjustment_p, - double *retro_p, - const int debug ) { + double *retro_p) { /*---------------------------------------------------------------------------- Do the drift adjustment calculation. @@ -992,8 +991,7 @@ do_adjustment(struct adjtime *adjtime_p, adjtime_p->last_adj_time, adjtime_p->not_adjusted, hclocktime, - &adjustment, &retro, - debug ); + &adjustment, &retro); if (adjustment > 0 || adjustment < -1) { set_hardware_clock_exact(hclocktime + adjustment, time_inc(read_time, -retro), @@ -1512,7 +1510,7 @@ #endif permitted = TRUE; else { /* program is designed to run setuid (in some situations) */ - if (set || hctosys || systohc || adjust) { + if (set || systohc || adjust) { fprintf(stderr, _("Sorry, only the superuser can change " "the Hardware Clock.\n")); -- 1.4.2.1 -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html