Re: a.out.h in text-utils/more.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 13, 2008 at 10:20:40AM -0400, Mike Frysinger wrote:
> any problems with dropping the a.out.h include in text-utils/more.c and 
> replacing the three defines with the actual constants ?  the constants are 

 Mike, you forgot to describe advantage of this change :-)

> already in the source, and it isnt like these are ever going to change ...

 Doesn't make sense to use macros from header files rather than
 hardcoded undocumented magic constants?

		case 0405:
		case 0411:
		case 0177545:
		case 0x457f:		/* simple ELF detection */

 ... is what?

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux