On Tue, May 13, 2008 at 10:20:40AM -0400, Mike Frysinger wrote: > any problems with dropping the a.out.h include in text-utils/more.c and > replacing the three defines with the actual constants ? the constants are Mike, you forgot to describe advantage of this change :-) > already in the source, and it isnt like these are ever going to change ... Doesn't make sense to use macros from header files rather than hardcoded undocumented magic constants? case 0405: case 0411: case 0177545: case 0x457f: /* simple ELF detection */ ... is what? Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html