On Sat, Apr 12, 2008 at 01:16:41PM +0100, James Youngman wrote: > On Wed, Apr 9, 2008 at 10:46 AM, Karel Zak <kzak@xxxxxxxxxx> wrote: > > > > Well, it seems we have worked on the same thing: > > http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/1371 > > > > So... see the patch below. It's based on both patches. > > Well first, sorry about the collision and extra work. I only > subscribed after making my patches. My mistake. No problem. > I like the patch you just posted. I only have two comments: > 1. The use of the variable name "fd" for a FILE* is a little confusing > to me, as I would normally expect "fd" to stand for "file descriptor" > and be a small integer returned by open(2), dup(2) etc. Ah.. yeah. I agree (I've originally used open(2) :-) > 2. Just putting "\n" in the scan format is not enough to verify that a > \n is actually in the input. See this example program: Hmm.. good point. Thanks for your review. I'll fix and commit the patch. Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
