On Thu, Feb 07, 2008 at 12:06:56AM +0100, Tilman Schmidt wrote: > Am 06.02.2008 01:27 schrieb Karel Zak: > >>+#ifndef N_GIGASET_M101 > >>+#define N_GIGASET_M101 16 > >>+#endif > > > > What about fallbacks for the others line disciplines (I assume there > > is dependence on kernel version)? > > N_GIGASET_M101 in v2.6.21 and, as I just noticed, N_SLCAN in upcoming > v2.6.25 are the only recent additions. Apart from these, the list of > line disciplines hasn't changed since kernel development moved to git. > Also I have omitted line disciplines which have an N_ code defined > but no implementation. OK. We have to support all v2.6.x kernels (optionally 2.4.x). > >>> i feel like "prog" should be a program-level static rather than passing > >>around > > > > glibc program_invocation_short_name ? :-) > > Sorry, I don't get the joke. Is that a serious suggestion? The program_invocation_short_name is a GNU extension and it's supported by glibc and uClibc. We already use it in setarch(8) and all out code is compiled with _GNU_SOURCE. So you can use it if you want. I don't have a strong opinion about it. Karel -- Karel Zak <kzak@xxxxxxxxxx> - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html