On Sun, Jan 13, 2008 at 01:24:48AM -0500, Mike Frysinger wrote: > On Sunday 13 January 2008, LaMont Jones wrote: > > +void usage(void) > > +{ > > + fprintf(stderr, _("usage: renice priority [ [ -p ] pids ] " > > + "[ [ -g ] pgrps ] [ [ -u ] users ]\n")); > > + exit(1); > > +} > usage should take an integer for its exit status, otherwise `renice --help` > incorrectly exits with 1 Actually, renice doesn't implement --help... > > + prio = strtol(*argv,&endptr,10); > missing spaces between , And all the other style issues. :-( Noted. I'll put a cleaner patch together tomorrow. lamont - To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html