Re: [Spam-fortigate] [PATCH] tailf: inotify based reimplementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 07, 2007 at 10:17:37AM +0800, Li Zefan wrote:
> > +	if (!lseek(fd, *size, SEEK_SET) != (off_t)-1) {
> 
> I think this should be:
> 
> 	if (lseek(fd, *size, SEEK_SET) != (off_t)-1)
> 
> Otherwise the if statement will be always true.

 Ah.. yes, stupid typo. Fixed.

> I don't see any other problems in the patch. 

 Applied, thanks for your feedback.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux