Re: fdisk: +size{k,K,m,M,g,G} chaos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> @@ -1184,18 +1184,22 @@ read_int(unsigned int low, unsigned int dflt, unsigned int high,
>                                                 i *= heads * sectors;
>                                         break;
>                                 case 'K':
> -                                       absolute = 1024;
> +                                       absolute = 2 << 10;     /* KiB */
2 << 10 == 2048

why not use 1 << 10?
>                                         break;
>                                 case 'k':
> -                                       absolute = 1000;
> +                                       absolute = 1000;        /* kB */
>                                         break;
> -                               case 'm':
>                                 case 'M':
> -                                       absolute = 1000000;
> +                                       absolute = 2 << 19;     /* MiB */
                                                     1 << 20?

> +                                       break;
> +                               case 'm':
> +                                       absolute = 1000000;     /* MB */
>                                         break;
> -                               case 'g':
>                                 case 'G':
> -                                       absolute = 1000000000;
> +                                       absolute = 2 << 29;     /* GiB */
                                                     1 << 30?

> +                                       break;
> +                               case 'g':
> +                                       absolute = 1000000000;  /* GB */
>                                         break;
>                                 default:
>                                         break;

Bert
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux