On Sun, Nov 04, 2007 at 04:15:36PM +0000, Samuel Thibault wrote:
> Hi,
>
> Mike Frysinger, le Sat 11 Aug 2007 22:48:43 -0400, a écrit :
> > > util-linux-2.13~rc3/configure.ac
> > > +case "${host_os}" in
> >
> > frivileous quoting
> >
> > > + linux*)
> >
> > breaks for uclinux targets ... so you either want:
> > *linux*)
> > or:
> > uclinux*|linux*)
> >
> > the former seems sane to me
> >
> > > util-linux-2.13~rc3/fdisk/fdisksunlabel.c
> > > +#ifdef __linux__
> > > #include <linux/major.h> /* FLOPPY_MAJOR */
> > > +#endif
> >
> > AC_CHECK_HEADER please
> >
> > > util-linux-2.13~rc3/login-utils/agetty.c
> > > +#elif defined(__GNU__)
> > > +#define _PATH_LOGIN "/bin/login"
> > > #endif
> >
> > i think it'd make sense for it to read !defined(_PATH_LOGIN)
>
> Ok, here is a fixed patch.
...
> --- a/login-utils/agetty.c
> +++ b/login-utils/agetty.c
> @@ -40,6 +40,8 @@
> #include "pathnames.h"
> #include <sys/param.h>
> #define USE_SYSLOG
> +#elif !defined(_PATH_LOGIN)
> +#define _PATH_LOGIN "/bin/login"
> #endif
hmm... what about to make include/pathnames.h more portable rather than
hardcode the path on two places?
Samuel, use Signed-Off-By in your patches, please.
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
